Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix account not found when doing local file editing. #5040

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Fix account not found when doing local file editing. #5040

merged 1 commit into from
Oct 17, 2022

Conversation

allexzander
Copy link
Contributor

Signed-off-by: alex-z blackslayer4@gmail.com

claucambra
claucambra approved these changes Oct 13, 2022
View reviewed changes
src/gui/accountmanager.cpp Outdated Show resolved Hide resolved
mgallien
mgallien reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review pending more thorough review

src/gui/accountmanager.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 13, 2022 •
edited
Loading

Codecov Report

Merging #5040 (4286099) into master (f9949ee) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 4286099 differs from pull request most recent head d64e4de. Consider uploading reports for the commit d64e4de to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5040      +/-   ##
==========================================
- Coverage   57.37%   57.35%   -0.03%     
==========================================
  Files         138      138              
  Lines       17418    17391      -27     
==========================================
- Hits         9993     9974      -19     
+ Misses       7425     7417       -8
Impacted Files Coverage Δ
src/libsync/propagateremotemkdir.cpp 65.03% <0.00%> (-0.70%) ⬇️
src/libsync/discovery.cpp 83.76% <0.00%> (-0.29%) ⬇️
src/libsync/networkjobs.cpp 50.00% <0.00%> (-0.29%) ⬇️
src/libsync/networkjobs.h 5.00% <0.00%> (+0.23%) ⬆️

@allexzander allexzander force-pushed the bugfix/local-editing-fix-account-not-found branch from b82ba9f to 8b4b916 Compare October 14, 2022 08:09
mgallien
mgallien reviewed Oct 14, 2022
View reviewed changes
src/libsync/account.cpp Outdated Show resolved Hide resolved
mgallien
mgallien requested changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes to Account::displayName() are wrong
display name has nothing to do with the user id stored in _davUser

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

42.9% 42.9% Coverage
0.0% 0.0% Duplication

mgallien
mgallien approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@allexzander allexzander force-pushed the bugfix/local-editing-fix-account-not-found branch 3 times, most recently from f2134ba to d64e4de Compare October 17, 2022 11:16
@allexzander
Fix account not found when doing local file editing.
4e2ea9c 
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/local-editing-fix-account-not-found branch from d64e4de to 4e2ea9c Compare October 17, 2022 11:56
@allexzander allexzander merged commit 3022363 into master Oct 17, 2022
@allexzander allexzander deleted the bugfix/local-editing-fix-account-not-found branch October 17, 2022 11:56
@allexzander
Copy link
Contributor Author

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 17, 2022
Closed
1 task
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5040-4e2ea9c00c4237521d99343167342969591760f9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.7.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @claucambra