Update CMake usage in README build instructions #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Oct 24, 2022
|
Thanks for the update to the docs :) |
claucambra
force-pushed
the
NeroBurner-patch-1
branch
from
5dbdf59 to
a1302e6
Compare
CMake 3.14.0 released in March 2019 [1] added the command line config options `-S <source-dir>` and `-B <build-dir>` and the build argument `--build <build-dir>` [2]. These options are universally valid independent of the build system used (`make`, `nmake`, `ninja`, `MSBuild`,...), making the provided CMake commands more generic. As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version. - [1] https://gitlab.kitware.com/cmake/cmake/-/tags/v3.14.0 - [2] https://cmake.org/cmake/help/v3.14/release/3.14.html#command-line - [3] https://packages.ubuntu.com/focal/cmake Signed-off-by: NeroBurner <pyro4hell@gmail.com>
mgallien
force-pushed
the
NeroBurner-patch-1
branch
from
a1302e6 to
6969292
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-5086-69692922cf1da8998aa76758c32400b73e3a73ad-x86_64.AppImage |
mgallien
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake 3.14.0 released in March 2019 [1] added the command line config options
-S <source-dir>and-B <build-dir>and the build argument--build <build-dir>[2]. These options are universally valid independent of the build system used (make,nmake,ninja,MSBuild,...), making the provided CMake commands more generic.As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version.
Signed-off-by: NeroBurner pyro4hell@gmail.com