Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit missing signal to update folder sync status icon #5087

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Oct 24, 2022

FIX: #4807

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/syncFolderStatusIcon branch from 56305c5 to 81f33ef Compare October 24, 2022 14:53
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5087-81f33ef94cbe84647cb916437ecbe494e4c57c02-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #5087 (81f33ef) into master (8ccb563) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5087      +/-   ##
==========================================
- Coverage   57.32%   57.14%   -0.18%     
==========================================
  Files         138      138              
  Lines       17426    17444      +18     
==========================================
- Hits         9990     9969      -21     
- Misses       7436     7475      +39     
Impacted Files Coverage Δ
src/libsync/clientsideencryption.cpp 26.33% <0.00%> (-0.48%) ⬇️
src/libsync/clientsideencryption.h 38.46% <ø> (ø)
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.00% <0.00%> (-2.38%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (-1.60%) ⬇️
src/libsync/syncengine.cpp 83.78% <0.00%> (-0.46%) ⬇️
src/libsync/propagatedownload.cpp 64.61% <0.00%> (-0.15%) ⬇️
src/libsync/filesystem.cpp 76.34% <0.00%> (+3.22%) ⬆️

@mgallien mgallien merged commit 4b2f103 into master Oct 24, 2022
@mgallien mgallien deleted the bugfix/syncFolderStatusIcon branch October 24, 2022 16:36
@mgallien mgallien added this to the 3.7.0 milestone Oct 24, 2022
@mgallien
Copy link
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: folder icon on client dashboard not showing green
3 participants