Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully qualify types in signals and slots #5088

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fully qualify types in signals and slots #5088

merged 1 commit into from
Nov 15, 2022

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien
Copy link
Collaborator Author

done using clazy to check for CLAZY_CHECKS="fully-qualified-moc-types"

claucambra
claucambra approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in principle, but this is going to cause a lot of merge conflict headaches with #4929 -- since this is just a clazy run, can we hold it back until that is merged?

@mgallien
Copy link
Collaborator Author

Looks fine in principle, but this is going to cause a lot of merge conflict headaches with #4929 -- since this is just a clazy run, can we hold it back until that is merged?

yes sure
no worries

@mgallien mgallien force-pushed the ci/clazyNotFullyQualifiedTypes branch from 812fb44 to 46aecd5 Compare November 14, 2022 15:20
@mgallien
fully qualify types in signals and slots
61c792c 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the ci/clazyNotFullyQualifiedTypes branch from 46aecd5 to 61c792c Compare November 15, 2022 09:01
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5088-61c792c6f4be4083292cef3d963b8ae4557465a7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit adb9176 into master Nov 15, 2022
@mgallien mgallien deleted the ci/clazyNotFullyQualifiedTypes branch November 15, 2022 10:02
@mgallien mgallien added this to the 3.7.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra