-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix instances of: c++11 range-loop might detach Qt container warnings #5089
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments that might be out of scope, but thought they were worth mentioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but, kindly see if you can fix our nitpicks on naming.
af55075
to
9abec54
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5089 +/- ##
=======================================
Coverage 57.71% 57.71%
=======================================
Files 138 138
Lines 17441 17441
=======================================
Hits 10066 10066
Misses 7375 7375
|
analyzed via clazy Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
9abec54
to
26fd4d2
Compare
SonarCloud Quality Gate failed. |
AppImage file: nextcloud-PR-5089-26fd4d222678015515439da5ba5c41d5f8e0d6c9-x86_64.AppImage |
analyzed via clazy
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com