Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show Sync Now button if account is connected #5097

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Oct 26, 2022

FIX: #5096

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@mgallien
Copy link
Collaborator

mgallien commented Oct 26, 2022

@jancborchardt @nimishavijay
I am not aware of our design guidelines with respect to enabled/disabled UI controls
should they be hidden or disabled but always shown ?
we have some situations for which the "sync now" button could be shown and enabled when it should not

❤️ @claucambra thanks for the fix, code wise looks good

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/sync-now-visible-connected branch from a617d6d to 09997b1 Compare October 29, 2022 13:54
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5097-09997b189f4a8fb64dc80e7e06e23783422131e0-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 09c6f5a into master Oct 29, 2022
@claucambra claucambra deleted the bugfix/sync-now-visible-connected branch October 29, 2022 15:03
@mgallien mgallien added this to the 3.7.0 milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: new Sync now button should be disabled when client is not connected
4 participants