Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal link share to the share dialog #5131

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

claucambra
Copy link
Collaborator

Re-implements a feature that we previously had in the QWidgets version

Screenshot 2022-11-04 at 20 00 24

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@claucambra claucambra self-assigned this Nov 4, 2022
@claucambra claucambra force-pushed the feature/implement-internal-link-share branch 4 times, most recently from 94f0a45 to 209685b Compare November 5, 2022 13:51
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5131-209685b093cdc0901aefc288c38cf08f450b74ae-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 3 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

src/gui/filedetails/sharemodel.cpp Outdated Show resolved Hide resolved
test/sharetestutils.cpp Show resolved Hide resolved
@claucambra claucambra force-pushed the feature/implement-internal-link-share branch 2 times, most recently from 1d0f0c5 to 209685b Compare December 13, 2022 16:30
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/implement-internal-link-share branch 2 times, most recently from 1a3a50f to 6cc5f82 Compare December 13, 2022 16:38
… FakePropfindReply being provided in tests

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/implement-internal-link-share branch from 6cc5f82 to b4ea35e Compare December 13, 2022 16:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit da2c978 into master Dec 13, 2022
@claucambra claucambra deleted the feature/implement-internal-link-share branch December 13, 2022 18:33
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants