Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share delegate button icon colors in dark mode #5132

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

claucambra
Copy link
Collaborator

With fix:

Screenshot 2022-11-04 at 20 05 19

Master:

Screenshot 2022-11-04 at 20 06 31

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@claucambra claucambra self-assigned this Nov 4, 2022
@mgallien mgallien force-pushed the bugfix/dark-mode-share-delegate-buttons branch 2 times, most recently from 03ea986 to c505f27 Compare November 8, 2022 15:43
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/dark-mode-share-delegate-buttons branch from c505f27 to 31a89c6 Compare November 8, 2022 16:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5132-31a89c68d75d6b60f2f2d2e456a302824780a769-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #5132 (31a89c6) into master (9e7a79f) will increase coverage by 0.26%.
The diff coverage is 70.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5132      +/-   ##
==========================================
+ Coverage   57.39%   57.66%   +0.26%     
==========================================
  Files         138      138              
  Lines       17444    17399      -45     
==========================================
+ Hits        10012    10033      +21     
+ Misses       7432     7366      -66     
Impacted Files Coverage Δ
src/libsync/capabilities.cpp 52.58% <0.00%> (-0.23%) ⬇️
src/libsync/discoveryphase.h 25.00% <ø> (ø)
src/libsync/discovery.cpp 88.03% <100.00%> (+4.26%) ⬆️
src/libsync/owncloudpropagator.cpp 86.04% <100.00%> (+0.16%) ⬆️
src/libsync/owncloudpropagator.h 68.65% <100.00%> (+0.23%) ⬆️
src/libsync/theme.cpp 14.13% <100.00%> (ø)
src/libsync/propagatedownload.cpp 63.58% <0.00%> (-1.18%) ⬇️
src/libsync/syncengine.cpp 84.16% <0.00%> (+0.45%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.31% <0.00%> (+1.81%) ⬆️
... and 2 more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 957caef into master Nov 8, 2022
@claucambra claucambra deleted the bugfix/dark-mode-share-delegate-buttons branch November 8, 2022 17:17
@mgallien mgallien added this to the 3.7.0 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants