Show file details within the tray dialog, rather than in a separate dialog

[claucambra]

Screen.Recording.2022-11-07.at.14.04.13.mov

Closes #4937

Please note that this PR depends on #5129

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

[jancborchardt]

Nice work @claucambra! It does seem like it could use a back arrow button in the top left for example, or "Cancel"?

However, on "Back" it should still be saved, whereas on "Cancel" all changes should be rolled back, which might be a bit complex. What do you think @claucambra @nimishavijay?

[claucambra]

Nice work @claucambra! It does seem like it could use a back arrow button in the top left for example, or "Cancel"?

However, on "Back" it should still be saved, whereas on "Cancel" all changes should be rolled back, which might be a bit complex. What do you think @claucambra @nimishavijay?

I'm not sure what's being more broadly suggested here -- are we talking about the possibility of backward/forward navigation? Or just, at its core, just different positioning of the buttons?

If it's the latter I think that is overkill -- we are just switching back and forth between a one page hierarchy, where the user can just re-click the share button in the main activity list to return to the file details page, and just click the "done" button to remove the file details page.

If it's the latter, that's okay, but it clashes with our "done/accept/cancel" button positioning in the rest of the application, which is always at the bottom (see the user status modal popup, for example)

EDIT: also, what changes are you suggesting should be able to roll back? I don't think a "settings menu" type paradigm where the settings can be changed and then be applied or not applied is not a good fit here (and I have my gripes with it in general, it has no place for non-destructive changes)

[jancborchardt]

Notes from the design review call:

• Only use ~90% of width, darken area outside on the left
• Also make user status drawer only 90% height
• Add x close button on top right instead of "Done" button
  • Also make left 10% darkened area clickable to go back
• Replace share button with 3 dots button
• Design updates for sharing actions: 🤝 Improvement to sharing design and flow server#26691
• Right-click menu:
  • Section 1: Open locally, Open in web, Open parent folder
  • Section 2: drawer tabs: Activity, Sharing, Versions, …

[claucambra]

@jancborchardt @nimishavijay Here is the current state of the file details drawer:

Screen.Recording.2022-11-09.at.13.12.04.mov

[claucambra]

Notes from the design review call:

• Only use ~90% of width, darken area outside on the left

• Also make user status drawer only 90% height

• Add x close button on top right instead of "Done" button

  • Also make left 10% darkened area clickable to go back

• Replace share button with 3 dots button

• Design updates for sharing actions: Improvement to sharing design and flow server#26691

• Right-click menu:

  • Section 1: Open locally, Open in web, Open parent folder
  • Section 2: drawer tabs: Activity, Sharing, Versions, …

Bullets 2 and 6->9 we will do in a separate PR :)

[jancborchardt]

Very nice! :)

[karlitschek]

Indeed very nice

[mgallien]

comments about some warnings coming from qml side
(see the inline comment)

there is also

qrc:/qml/src/gui/tray/Window.qml:190:30: QML FileDetailsPage: Binding loop detected for property "implicitHeight"

[claucambra]

comments about some warnings coming from qml side (see the inline comment)

there is also

qrc:/qml/src/gui/tray/Window.qml:190:30: QML FileDetailsPage: Binding loop detected for property "implicitHeight"

Is fixed now :)

[codecov]

Codecov Report

Merging #5139 (04a3baa) into master (6db9c95) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 04a3baa differs from pull request most recent head 5930fb4. Consider uploading reports for the commit 5930fb4 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5139      +/-   ##
==========================================
- Coverage   57.63%   57.54%   -0.09%     
==========================================
  Files         138      138              
  Lines       17490    17399      -91     
==========================================
- Hits        10081    10013      -68     
+ Misses       7409     7386      -23     

Impacted Files	Coverage Δ
src/common/syncfilestatus.h	50.00% <0.00%> (-50.00%)	⬇️
src/libsync/propagatorjobs.cpp	71.12% <0.00%> (-3.88%)	⬇️
src/libsync/syncfileitem.cpp	94.91% <0.00%> (-3.39%)	⬇️
src/libsync/discovery.h	57.14% <0.00%> (-2.12%)	⬇️
src/libsync/syncfileitem.h	39.65% <0.00%> (-1.73%)	⬇️
src/libsync/filesystem.cpp	73.11% <0.00%> (-1.08%)	⬇️
src/common/syncjournaldb.cpp	77.63% <0.00%> (-0.30%)	⬇️
src/libsync/account.h	33.33% <0.00%> (ø)
src/libsync/syncengine.h	50.00% <0.00%> (ø)
src/libsync/discoveryphase.h	25.00% <0.00%> (ø)
... and 4 more

[claucambra]

Note to self: will need incorporating changes from #5194

[allexzander]

@claucambra I am not able to open the tray with this PR.

[claucambra]

@claucambra I am not able to open the tray with this PR.

rebase issue, fixed now

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5139-5930fb4ac912d33ba431a017cef103c9cf8cbc6c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

11.1% Coverage
0.0% Duplication