Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize WebView widget once the loginpage rendered #5161

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

xllndr
Copy link
Contributor

@xllndr xllndr commented Nov 10, 2022

When the login dialogue displays the login page itself the WebView widget did not resize according to
the dimensions of the login page.

Fixes #5160

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #5161 (54aa9e8) into master (7d093b1) will decrease coverage by 1.24%.
The diff coverage is n/a.

❗ Current head 54aa9e8 differs from pull request most recent head 664e0c1. Consider uploading reports for the commit 664e0c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
- Coverage   58.95%   57.71%   -1.24%     
==========================================
  Files         143      138       -5     
  Lines       18312    17441     -871     
==========================================
- Hits        10795    10066     -729     
+ Misses       7517     7375     -142     
Impacted Files Coverage Δ
src/libsync/propagateremotemkdir.h 0.00% <0.00%> (-75.00%) ⬇️
src/libsync/bandwidthmanager.h 0.00% <0.00%> (-60.00%) ⬇️
src/libsync/progressdispatcher.h 0.00% <0.00%> (-44.45%) ⬇️
src/libsync/clientsideencryptionjobs.cpp 0.00% <0.00%> (-43.97%) ⬇️
src/libsync/syncresult.cpp 9.57% <0.00%> (-26.60%) ⬇️
src/libsync/theme.h 33.33% <0.00%> (-16.67%) ⬇️
src/libsync/syncengine.h 50.00% <0.00%> (-15.00%) ⬇️
src/libsync/clientsideencryptionjobs.h 0.00% <0.00%> (-10.00%) ⬇️
src/libsync/abstractnetworkjob.h 45.45% <0.00%> (-8.40%) ⬇️
src/common/syncjournaldb.h 66.66% <0.00%> (-8.34%) ⬇️
... and 63 more

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution!

@claucambra
Copy link
Collaborator

claucambra commented Nov 26, 2022

@xlindr could you remove the merge commits? once these are removed we will be able to merge your changes to master :)

@xllndr
Copy link
Contributor Author

xllndr commented Dec 5, 2022

Hello @claucambra, I just pushed again without any merge commits, now you should be able to merge into master, thank you!

@xllndr
Copy link
Contributor Author

xllndr commented Feb 8, 2023

Hello @claucambra is there anyway I can help to speed up the merge into upstream so the changes get into the next version? This fix is highly appreciated by some people.

When the login dialogue displays the login page itself
the WebView widget did not resize according to
the dimensions of the login page.

Signed-off-by: Axel Lender <lender@b1-systems.de>
@xllndr
Copy link
Contributor Author

xllndr commented Mar 7, 2023

Hello @claucambra thank you for acting quickly last time I commented. What can I do to help this PR to be merged for the next release? Or can I reach out to someone else?

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5161-664e0c18ec3273d6b4364c9c49f77d88211962e4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator

Hello @claucambra thank you for acting quickly last time I commented. What can I do to help this PR to be merged for the next release? Or can I reach out to someone else?

Yeah, sorry for losing track of this PR

Will merge once pipeline is complete :)

@claucambra claucambra merged commit f0ddc54 into nextcloud:master Mar 7, 2023
@claucambra
Copy link
Collaborator

/backport to stable-3.7

@xllndr
Copy link
Contributor Author

xllndr commented Mar 7, 2023

Thank you very much @claucambra

@claucambra
Copy link
Collaborator

Thank you very much @claucambra

No worries, thanks for your contribution!

@mgallien mgallien added this to the 3.8.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Login dialogue too small, not correctly displaying login page with WebView
6 participants