-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize WebView widget once the loginpage rendered #5161
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5161 +/- ##
==========================================
- Coverage 58.95% 57.71% -1.24%
==========================================
Files 143 138 -5
Lines 18312 17441 -871
==========================================
- Hits 10795 10066 -729
+ Misses 7517 7375 -142
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the contribution!
@xlindr could you remove the merge commits? once these are removed we will be able to merge your changes to master :) |
Hello @claucambra, I just pushed again without any merge commits, now you should be able to merge into master, thank you! |
Hello @claucambra is there anyway I can help to speed up the merge into upstream so the changes get into the next version? This fix is highly appreciated by some people. |
When the login dialogue displays the login page itself the WebView widget did not resize according to the dimensions of the login page. Signed-off-by: Axel Lender <lender@b1-systems.de>
Hello @claucambra thank you for acting quickly last time I commented. What can I do to help this PR to be merged for the next release? Or can I reach out to someone else? |
AppImage file: nextcloud-PR-5161-664e0c18ec3273d6b4364c9c49f77d88211962e4-x86_64.AppImage |
Yeah, sorry for losing track of this PR Will merge once pipeline is complete :) |
/backport to stable-3.7 |
Thank you very much @claucambra |
No worries, thanks for your contribution! |
When the login dialogue displays the login page itself the WebView widget did not resize according to
the dimensions of the login page.
Fixes #5160