Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove close/dismiss button from encryption message #5163

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

claucambra
Copy link
Collaborator

Screenshot 2022-11-10 at 17 08 06

Part of #5126

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #5163 (c6782ba) into master (ab8f0db) will decrease coverage by 0.23%.
The diff coverage is n/a.

❗ Current head c6782ba differs from pull request most recent head 0262c77. Consider uploading reports for the commit 0262c77 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5163      +/-   ##
==========================================
- Coverage   57.80%   57.56%   -0.24%     
==========================================
  Files         138      138              
  Lines       17441    17399      -42     
==========================================
- Hits        10082    10016      -66     
- Misses       7359     7383      +24     
Impacted Files Coverage Δ
src/common/syncfilestatus.h 50.00% <0.00%> (-50.00%) ⬇️
src/libsync/vfs/cfapi/hydrationjob.cpp 52.38% <0.00%> (-3.71%) ⬇️
src/libsync/syncfileitem.cpp 94.91% <0.00%> (-3.39%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.00% <0.00%> (-2.38%) ⬇️
src/libsync/discovery.h 57.14% <0.00%> (-2.12%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (-1.82%) ⬇️
src/libsync/propagatorjobs.cpp 73.23% <0.00%> (-1.77%) ⬇️
src/libsync/syncfileitem.h 39.65% <0.00%> (-1.73%) ⬇️
src/libsync/filesystem.cpp 73.11% <0.00%> (-1.08%) ⬇️
src/common/syncjournaldb.cpp 77.63% <0.00%> (-0.30%) ⬇️
... and 5 more

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/encryption-ux branch from c6782ba to 0262c77 Compare November 28, 2022 17:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit ceb998f into master Nov 28, 2022
@claucambra claucambra deleted the feature/encryption-ux branch November 28, 2022 17:54
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5163-0262c77d27221a6484e86576eea78a8d11cdb10b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants