Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to inexistent property in NCCustomButton #5173

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

claucambra
Copy link
Collaborator

Fixes a number of warnings in logs

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@claucambra claucambra self-assigned this Nov 14, 2022
@mgallien mgallien force-pushed the bugfix/nccustombutton-warnings branch from 4b180d8 to 1fb1188 Compare November 15, 2022 08:25
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/nccustombutton-warnings branch from 1fb1188 to 561b558 Compare November 15, 2022 10:48
@claucambra claucambra merged commit a437a99 into master Nov 15, 2022
@claucambra claucambra deleted the bugfix/nccustombutton-warnings branch November 15, 2022 10:51
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5173-561b55800ca9ce58774bdeec283285ac28451c1c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants