cmake: Use FindPkgConfig's pkg_get_variable instead of custom macro #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
force-pushed
the
cmake-pkg_get_variable
branch
from
834bfb5 to
5232190
Compare
Commit b34a901 ("Use FindPkgConfig to find libcloudproviders and related libs") introduced the usage of cmake's FindPkgConfig module which provides `pkg_get_variable` since version 3.4 that can be used instead of the custom `PKGCONFIG_GETVAR` macro Signed-off-by: Marvin Schmidt <marv@exherbo.org>
claucambra
force-pushed
the
cmake-pkg_get_variable
branch
from
5232190 to
7f72678
Compare
|
AppImage file: nextcloud-PR-5199-7f72678d32951b83eb51ee2edabccc1b744a08e5-x86_64.AppImage |
Thank you for taking care of this so quickly 👍 |
No worries, thank you for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit b34a901 ("Use FindPkgConfig to find libcloudproviders and related libs") introduced the usage of cmake's FindPkgConfig module which provides
pkg_get_variablesince version 3.4 that can be used instead of the customPKGCONFIG_GETVARmacroSigned-off-by: Marvin Schmidt marv@exherbo.org