Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles #5214

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

claucambra
Copy link
Collaborator

This should avoid any unpleasant or unexpected surprises

This PR also contains some fixes that are visible when compiling with Qt 6

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

…gs with alternate QtQuick styles

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/user-status-selector-text-input-sizing branch from 153176c to cc159e0 Compare December 8, 2022 12:07
@claucambra claucambra merged commit 9f7592f into master Dec 8, 2022
@claucambra claucambra deleted the bugfix/user-status-selector-text-input-sizing branch December 8, 2022 12:30
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5214-cc159e0117e4839f4da51bd206a6c7218bcd905c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants