Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused HeaderBanner component #5245

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

claucambra
Copy link
Collaborator

We don't actually use this component anywhere anymore, despite there remaining a loose member pointer in webflowcredentialsdialog

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@claucambra claucambra self-assigned this Dec 7, 2022
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/remove-unused-headerbanner branch from 2698b81 to 4ab7d64 Compare December 15, 2022 11:30
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5245-4ab7d6484a05bf825161ec13a0ae494164bfb873-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 4b4f4b1 into master Dec 15, 2022
@claucambra claucambra deleted the bugfix/remove-unused-headerbanner branch December 15, 2022 12:12
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants