Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue #5272

Merged

Conversation

claucambra
Copy link
Collaborator

FSEventStreamScheduleWithRunLoop is now deprecated since macOS 13.0

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

…treamSetDispatchQueue

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/fseventstreamscehdulerunloop-deprecation-fix branch from aa9f420 to 784327f Compare January 2, 2023 17:05
@sonarcloud
Copy link

sonarcloud bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #5272 (784327f) into master (4dd2221) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5272   +/-   ##
=======================================
  Coverage   57.59%   57.59%           
=======================================
  Files         139      139           
  Lines       17631    17631           
=======================================
  Hits        10154    10154           
  Misses       7477     7477           
Impacted Files Coverage Δ
src/libsync/theme.h 33.33% <ø> (ø)

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5272-784327f48976b97434d8c1a340ce926ca95e6c23-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 2e0680e into master Jan 2, 2023
@claucambra claucambra deleted the bugfix/fseventstreamscehdulerunloop-deprecation-fix branch January 2, 2023 18:34
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants