Fix full-text search results not being opened in browser

[claucambra]

The full-text search app provides incomplete resource URLs unlike all other search result apps, meaning our default behaviour for opening search results in the browser does not work

This PR adds a procedure to compensate for this

Closes #5113 and nextcloud/fulltextsearch#728

[tobiasKaminsky]

The full-text search app provides incomplete resource URLs unlike all other search result apps, meaning our default behaviour for opening search results in the browser does not work

Great!
Can you create an issue on FTS so that every result provides the entire link?
Then we can eliminate this workaround at some point again and it is also consistent with other search results (e.g. unified search).

[claucambra]

The full-text search app provides incomplete resource URLs unlike all other search result apps, meaning our default behaviour for opening search results in the browser does not work

Great! Can you create an issue on FTS so that every result provides the entire link? Then we can eliminate this workaround at some point again and it is also consistent with other search results (e.g. unified search).

done 🙂

[codecov]

Codecov Report

Merging #5279 (4812989) into master (34240e1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5279   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files         139      139           
  Lines       17631    17631           
=======================================
  Hits        10153    10153           
  Misses       7478     7478           

Impacted Files	Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp	72.95% <0.00%> (-0.23%)	⬇️
src/libsync/owncloudpropagator.h	68.65% <0.00%> (+0.74%)	⬆️

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5279-481298997c276f858871c499bb5eed085474e7bf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

55.6% Coverage
0.0% Duplication

[arnowelzel]

Sorry - but the fix does not work with Nextcloud Client 3.7.4.

The format of the URL is wrong. What ever is called by the client, it will end up in a URL like this: https://server.example/apps/files/?dir=/&fileid=362

However, this won't work: the directory is not / but a subfolder like /program2022/finished/text12.docx