Drop dependency on Qt Quick Controls 1 #5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Jan 5, 2023
|
Big thanks for your contribution, this is nice :) |
|
/backport to stable-3.6 |
mgallien
force-pushed
the
drop-qtquickcontrols1
branch
from
600ad8f to
32a92e2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5309 +/- ##
=======================================
Coverage 57.59% 57.59%
=======================================
Files 139 139
Lines 17631 17631
=======================================
Hits 10154 10154
Misses 7477 7477 |
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing those imports will cause the QMl script to use the according API from Quick Controls 2, which are, fortunately largely API-comptible. This helps distribution to deprecate and remove Quick Controls 1 [2]. 1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1 2: https://bugs.gentoo.org/889772 Signed-off-by: Florian Schmaus <flo@geekplace.eu>
claucambra
force-pushed
the
drop-qtquickcontrols1
branch
from
32a92e2 to
14cbd83
Compare
|
AppImage file: nextcloud-PR-5309-14cbd836abe4855cb927a1d87d8a71e30b1bb81e-x86_64.AppImage |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing those imports will cause the QMl script to use the according API from Quick Controls 2, which are, fortunately largely API-comptible.
This helps distribution to deprecate and remove Quick Controls 1 [2].
1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772