Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to lock folders when editing locally #5317

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

claucambra
Copy link
Collaborator

Folders can't be locked, so don't try to do this when opening an edit locally request

Fixes #5308

Signed-off-by: Claudio Cambra claudio.cambra@nextcloud.com

@claucambra claucambra self-assigned this Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #5317 (0ab2bd8) into master (57a674c) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5317   +/-   ##
=======================================
  Coverage   57.38%   57.38%           
=======================================
  Files         139      139           
  Lines       17697    17697           
=======================================
+ Hits        10155    10156    +1     
+ Misses       7542     7541    -1     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 73.18% <0.00%> (+0.22%) ⬆️

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/edit-locally-folder-lock branch from 11c481d to 0ab2bd8 Compare January 23, 2023 16:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit d69583b into master Jan 23, 2023
@claucambra claucambra deleted the bugfix/edit-locally-folder-lock branch January 23, 2023 17:41
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5317-0ab2bd849bd86df4bcecedf02b1d3ff33d671aec-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Don't lock when using "Edit locally" on folders
4 participants