Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.5] Open calendar notifications in the browser. #5375

Closed
wants to merge 2 commits into from
Closed

[stable-3.5] Open calendar notifications in the browser. #5375

wants to merge 2 commits into from

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4684

Camila added 2 commits January 30, 2023 08:44
@backportbot-nextcloud
Open calendar notifications in the browser.
0f6e7c3 
Signed-off-by: Camila <hello@camila.codes>
@backportbot-nextcloud
Update tests for ActivityData.
289d6b6 
Signed-off-by: Camila <hello@camila.codes>
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-5375-289d6b6ff5b5d4536894f57ddd7ed7dbc3a107d6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nickvergessen nickvergessen removed their request for review January 30, 2023 09:24
claucambra
claucambra reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilasan do we intend to backport this to 3.5?

@camilasan
Copy link
Member

This is not needed anymore.

@camilasan camilasan closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra left review comments

@allexzander allexzander Awaiting requested review from allexzander

@camilasan camilasan Awaiting requested review from camilasan

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-desktop-bot @camilasan @claucambra