Fix share dialog infinite loading #5442
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5442 +/- ##
==========================================
+ Coverage 57.79% 57.82% +0.02%
==========================================
Files 141 141
Lines 18147 18147
==========================================
+ Hits 10488 10493 +5
+ Misses 7659 7654 -5
|
|
/backport to stable-3.7 |
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ermissions that would have previously prevented sharing Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/fix-share-load
branch
from
af0349c to
89ebfca
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Hi @claucambra, Thanks a lot for the work. I have 2 questions for you :
Best regards, |
|
AppImage file: nextcloud-PR-5442-89ebfcae8e2a2dde19ff54ef15bd9e5100bac322-x86_64.AppImage |
Hi Jérôme, this fix applies to all platforms, so users on Windows and macOS will not encounter the issue on the next release. As for the release date of 3.7.4, we do not yet know -- likely within the next couple of weeks. |
|
couple of weeks????? |
|
Wow, I noticed that 3.7.2 and 3.7.3 was released on the same date. With such a bug that is going on, I will assume there should be an update made available as a matter of urgency. The whole system is designed to share files and the basic feature is not available. Please Nextcloud, release the new version today. My clients are shouting. |
|
@alepensato @JohanBoshoffWebAware we are actively working on bugfixes for other issues that need to be merged before we can release 3.7.4 In the meantime, a temporary solution would be to do any of: A) Set more permissive share permissions by default on the server -- the bug is only present on servers where the default is to not allow resharing of shared files macOS: https://cloud.nextcloud.com/s/EdnRpDkqmeSFNKo Please note that these builds are not stable and you might encounter unforeseen bugs |
|
Thank you for the patch build. Please note that I changed the sharing settings to include Reshare, but with the current 3.7.3 client, the share dialogue box still only turns and nothing happens. With the patch version installed, everything is working perfectly fine. Thank you. |
|
No changes with the patched version installed, |
I'll run a rebuilt of the windows client to double-check |
|
updates? |
|
The problem goes away on latest Nextcloud 25.03 using the normal client app. However, Nextcloud 25.03 has a huge bug that breaks custom theme which happened to me and I have to wait for a fix in the next update. |
|
mmmm I have Nextcloud 25.0.3 and latest desktop app, and the problem is alway present |
|
Do you have the setting on under Administration Settings under the Share tab for Default Share Permissions to allow reshare? |
|
No, users should not able to reshare a shared folder/file |
|
All I did was enable the setting, save and disable the setting and it worked well for me. |
|
Daily windows build from 23/02 should now include the fix: https://download.nextcloud.com/desktop/daily/windows/windows-20230223.msi |
|
it does not works, always stay in loop |
okay; I will start a build from master, and if that one does not work either then let's investigate further |
|
These are my shared setting configured on the server and the log from the windows client
|
The relevant options are reshare (which I think is Ri-condividi, but my Italian is not great). Try these options:
|
|
No changes with this configuration |
|
Have you
Have you restarted the client since changing this setting? |
|
yes sure |
Let's try this build as the final test: https://cloud.nextcloud.com/s/LJ5d6faPN3ogsjx If it still has infinite loading for you, then please attach the desktop client logs (either the full debug archive or, even better, logs around the time you try to open the share dialog) |
|
it still has infinite loading. |
Yes. You are getting infinite loading because your server has link shares disabled or not available. This is still a bug, but enabling link shares should work around the infinite loading I will take a closer look at the code in the morning... |
Restrictive file sharing defaults from the server can cause the client to assume the worst at the start, and then we don't try to reinitialise the share manager when we get more permissive sharing permissions from the server -- causing the infinite loop as sharing is allowed, but the manager is never initialised
Now we reinitialise the manager if we have received nice permissions on PROPFIND
Fixes #5411