Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edit locally job not finding the user account: wrong user id #5444

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

mgallien
Copy link
Collaborator

the only correct id for an user is Account::_davUser

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #5444 (24fc49f) into master (8843ea7) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5444      +/-   ##
==========================================
- Coverage   57.81%   57.80%   -0.01%     
==========================================
  Files         141      141              
  Lines       18147    18143       -4     
==========================================
- Hits        10492    10488       -4     
  Misses       7655     7655              
Impacted Files Coverage Δ
src/libsync/account.cpp 36.19% <0.00%> (+0.26%) ⬆️
src/libsync/propagateremotemkdir.h 50.00% <0.00%> (-25.00%) ⬇️
src/libsync/propagatedownload.cpp 65.82% <0.00%> (-0.71%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.95% <0.00%> (-0.23%) ⬇️
src/libsync/owncloudpropagator.h 65.87% <0.00%> (+0.79%) ⬆️
src/libsync/propagatorjobs.cpp 78.14% <0.00%> (+1.09%) ⬆️

@mgallien mgallien force-pushed the bugfix/useProperUserIdForEditLocally branch from b682cba to 7655e6a Compare February 16, 2023 13:18
@mgallien
Copy link
Collaborator Author

/backport to stable-3.7

the only correct id for an user is Account::_davUser

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/useProperUserIdForEditLocally branch from 7655e6a to 24fc49f Compare February 17, 2023 08:47
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5444-24fc49f99dd6da5b571af42ae3cacf33994fbe54-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit ec7fd95 into master Feb 17, 2023
@mgallien mgallien deleted the bugfix/useProperUserIdForEditLocally branch February 17, 2023 10:21
@mgallien mgallien added this to the 3.8.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants