Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.7] Fix infinite loading in the share dialog when public link shares are disabled on the server #5489

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5472

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #5489 (2841647) into stable-3.7 (888face) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 2841647 differs from pull request most recent head 9192239. Consider uploading reports for the commit 9192239 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.7    #5489      +/-   ##
==============================================
- Coverage       57.91%   57.90%   -0.02%     
==============================================
  Files             141      141              
  Lines           18150    18150              
==============================================
- Hits            10512    10510       -2     
- Misses           7638     7640       +2     
Impacted Files Coverage Δ
src/libsync/propagateremotemkdir.h 50.00% <0.00%> (-25.00%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.95% <0.00%> (-0.23%) ⬇️

@mgallien mgallien force-pushed the backport/5472/stable-3.7 branch from cc4d9a0 to 2841647 Compare March 8, 2023 12:29
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5489-2841647bf2f384b8a5e5cc51cf83a571d6f4632f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…t available

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…er than repeating each time this method is called

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the backport/5472/stable-3.7 branch from 2841647 to 9192239 Compare March 8, 2023 13:58
@mgallien mgallien merged commit 972e04b into stable-3.7 Mar 8, 2023
@mgallien mgallien deleted the backport/5472/stable-3.7 branch March 8, 2023 14:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants