Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests SecureFileDrop #5574

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Apr 4, 2023

Private and Public keys and a Certificate are created locally and are meant to be used for end-to-end testing only, to emulate real client-side encryption keypair

@allexzander allexzander force-pushed the bugfix/unit-test-securefiledrop branch from c9a1eba to c09b25b Compare April 4, 2023 19:32
@allexzander allexzander requested a review from mgallien April 4, 2023 19:33
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5574 (31c3aee) into master (a444564) will increase coverage by 0.36%.
The diff coverage is 42.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5574      +/-   ##
==========================================
+ Coverage   58.88%   59.25%   +0.36%     
==========================================
  Files         143      143              
  Lines       18331    18435     +104     
==========================================
+ Hits        10795    10924     +129     
+ Misses       7536     7511      -25     
Impacted Files Coverage Δ
src/common/syncjournalfilerecord.h 54.54% <0.00%> (-5.46%) ⬇️
src/libsync/capabilities.h 0.00% <ø> (ø)
src/libsync/encryptfolderjob.cpp 0.00% <0.00%> (ø)
src/libsync/propagatedownload.h 39.47% <0.00%> (-1.07%) ⬇️
src/libsync/propagatedownloadencrypted.cpp 0.00% <0.00%> (ø)
src/libsync/propagateremotedeleteencrypted.cpp 0.00% <0.00%> (ø)
...bsync/propagateremotedeleteencryptedrootfolder.cpp 0.00% <0.00%> (ø)
src/libsync/propagateupload.cpp 76.36% <ø> (ø)
src/libsync/propagateuploadencrypted.cpp 0.00% <0.00%> (ø)
src/libsync/vfs/cfapi/hydrationjob.cpp 51.56% <0.00%> (ø)
... and 17 more

src/libsync/clientsideencryption.h Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the bugfix/unit-test-securefiledrop branch from 02bbd98 to 9574e7f Compare April 5, 2023 09:08
@allexzander allexzander requested a review from mgallien April 5, 2023 10:18
Signed-off-by: alex-z <blackslayer4@gmail.com>
@mgallien
Copy link
Collaborator

mgallien commented Apr 5, 2023

/backport to stable-3.8

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 10 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5574-31c3aee447bba3627a824cfa11bb318ab5fdf523-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit c3c1b1e into master Apr 5, 2023
@allexzander allexzander deleted the bugfix/unit-test-securefiledrop branch April 5, 2023 19:13
@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants