Properly handle all fatal errors during edit locally setup procedure #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
approved these changes
Apr 12, 2023
mgallien
approved these changes
Apr 12, 2023
mgallien
force-pushed
the
bugfix/edit-locally-error-messages
branch
from
b65040d to
1c720d8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5583 +/- ##
==========================================
- Coverage 59.28% 59.25% -0.04%
==========================================
Files 143 143
Lines 18445 18453 +8
==========================================
- Hits 10936 10935 -1
- Misses 7509 7518 +9
|
mgallien
force-pushed
the
bugfix/edit-locally-error-messages
branch
2 times, most recently
from
442e682 to
cec1171
Compare
|
@claucambra can you check why a test seems to fail every time ? |
|
AppImage file: nextcloud-PR-5583-cec1171add9e9d871d659ba7aca53f72d5cc1101-x86_64.AppImage |
It's an end-to-end test unrelated to the changes in this PR |
…art it within the job Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ng edit locally Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ors are met during edit locally Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
claucambra
force-pushed
the
bugfix/edit-locally-error-messages
branch
from
cec1171 to
348c253
Compare
|
SonarCloud Quality Gate failed. |
|
/backport to stable-3.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix situations where the edit locally loading dialog is presented but never destroyed when an error is met during setup