Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse sharees 'lookup' key to include federated sharees. #5613

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander
Copy link
Contributor Author

/backport to stable-3.8

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #5613 (6bb0640) into master (9371931) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
- Coverage   59.28%   59.26%   -0.03%     
==========================================
  Files         143      143              
  Lines       18445    18445              
==========================================
- Hits        10936    10932       -4     
- Misses       7509     7513       +4     

see 2 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5613-6bb0640988cfd2bf81c12aa3350369d7c268f036-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 8ef2154 into master Apr 24, 2023
@allexzander allexzander deleted the bugfix/sharees-parse-lookup branch April 24, 2023 06:37
@allexzander
Copy link
Contributor Author

/backport to stable-3.8

@backportbot-nextcloud
Copy link

The backport to stable-3.8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.8
git pull origin/stable-3.8

# Create the new backport branch
git checkout -b fix/foo-stable-3.8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.8

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mgallien mgallien added this to the 3.9.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants