New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit locally. Fix crash on _chekTokenJob pointer deref. #5637

Merged

allexzander merged 1 commit into master from bugfix/fix-crash-ptr-deref

May 4, 2023

Contributor

allexzander commented Apr 28, 2023

No description provided.

Contributor Author

allexzander commented Apr 28, 2023

/backport to stable-3.8

backportbot-nextcloud bot added the backport-request label

codecov bot commented Apr 28, 2023 •

edited

Loading

Codecov Report

Merging #5637 (9aa052f) into master (daf748b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 9aa052f differs from pull request most recent head cda8da3. Consider uploading reports for the commit cda8da3 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5637      +/-   ##
==========================================
- Coverage   59.28%   59.27%   -0.02%     
==========================================
  Files         143      143              
  Lines       18455    18455              
==========================================
- Hits        10941    10939       -2     
- Misses       7514     7516       +2

see 4 files with indirect coverage changes

allexzander requested review from claucambra, mgallien and camilasan and removed request for claucambra

April 28, 2023 14:25

claucambra approved these changes

View reviewed changes


          Edit locally. Fix crash on _chekTokenJob pointer deref.

cda8da3

Signed-off-by: alex-z <blackslayer4@gmail.com>

allexzander force-pushed the bugfix/fix-crash-ptr-deref branch from 9aa052f to cda8da3 Compare

May 4, 2023 08:50

allexzander merged commit cc69701 into master

allexzander deleted the bugfix/fix-crash-ptr-deref branch

May 4, 2023 09:33

backportbot-nextcloud bot mentioned this pull request

[stable-3.8] Edit locally. Fix crash on _chekTokenJob pointer deref. #5647

Merged

backportbot-nextcloud bot removed the backport-request label

nextcloud-desktop-bot commented May 4, 2023

AppImage file: nextcloud-PR-5637-cda8da3e9601fc15b633d6c7ceee3d59f3cb7f97-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

sonarqubecloud bot commented May 4, 2023

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

mgallien added this to the 3.9.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet