Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask before importing accounts from legacy clients #5654

Merged
merged 8 commits into from
May 16, 2023

Conversation

claucambra
Copy link
Collaborator

Displays dialog asking user to confirm if they'd like to attempt an import of legacy accounts.

Also adds a command line argument to force imports if needed

Closes #5556

@claucambra claucambra self-assigned this May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #5654 (ece2632) into master (79c0fdc) will decrease coverage by 0.15%.
The diff coverage is n/a.

❗ Current head ece2632 differs from pull request most recent head 3dd838d. Consider uploading reports for the commit 3dd838d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5654      +/-   ##
==========================================
- Coverage   59.38%   59.23%   -0.15%     
==========================================
  Files         143      143              
  Lines       18524    18458      -66     
==========================================
- Hits        11000    10934      -66     
  Misses       7524     7524              

see 14 files with indirect coverage changes

src/gui/application.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/ask-before-importing-legacy branch 2 times, most recently from 38cddd0 to ece2632 Compare May 8, 2023 15:42
@claucambra claucambra requested a review from allexzander May 8, 2023 15:59
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…one in other classes

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…gacy import

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/ask-before-importing-legacy branch from ece2632 to 3dd838d Compare May 16, 2023 13:23
@claucambra claucambra merged commit 6ff45bf into master May 16, 2023
@claucambra claucambra deleted the bugfix/ask-before-importing-legacy branch May 16, 2023 14:01
@claucambra
Copy link
Collaborator Author

/backport to stable-3.8

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5654-3dd838d28dba739d0679479bb5fe9e1748db9d51-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Client uses ownCloud configuration on first start
5 participants