Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2EE. Fix freeze on metadata checksum validation. #5655

Merged
merged 1 commit into from
May 8, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander force-pushed the bugfix/e2ee-checksum-validation-freeze-fix branch from 76da32d to b0fe2b0 Compare May 5, 2023 14:51
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #5655 (90e3a37) into master (c1bfd8b) will increase coverage by 0.11%.
The diff coverage is 27.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5655      +/-   ##
==========================================
+ Coverage   59.24%   59.36%   +0.11%     
==========================================
  Files         143      143              
  Lines       18445    18443       -2     
==========================================
+ Hits        10928    10948      +20     
+ Misses       7517     7495      -22     
Impacted Files Coverage Δ
src/libsync/clientsideencryption.cpp 41.25% <0.00%> (+0.40%) ⬆️
src/libsync/clientsideencryption.h 35.71% <ø> (ø)
src/libsync/owncloudpropagator.cpp 84.62% <0.00%> (-0.33%) ⬇️
src/libsync/syncengine.cpp 81.15% <33.33%> (+0.22%) ⬆️
src/libsync/account.cpp 36.08% <60.00%> (+0.22%) ⬆️
src/libsync/account.h 40.00% <100.00%> (+3.15%) ⬆️

... and 4 files with indirect coverage changes

@allexzander allexzander force-pushed the bugfix/e2ee-checksum-validation-freeze-fix branch 3 times, most recently from 69eea9a to befb7bd Compare May 8, 2023 08:31
@allexzander
Copy link
Contributor Author

/backport to stable-3.8

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides tiny pedantic comment, LGTM

src/libsync/owncloudpropagator.cpp Outdated Show resolved Hide resolved
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/e2ee-checksum-validation-freeze-fix branch from cd2d647 to 90e3a37 Compare May 8, 2023 09:29
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5655-90e3a37a20019d34826e450c08d685520dc9b54e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 8 Code Smells

14.3% 14.3% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 7a01e62 into master May 8, 2023
@allexzander allexzander deleted the bugfix/e2ee-checksum-validation-freeze-fix branch May 8, 2023 10:24
@mgallien mgallien added this to the 3.9.0 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants