Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use addLayout to insert the VFS option when setting account. #5665

Merged
merged 1 commit into from
May 9, 2023
Merged

Use addLayout to insert the VFS option when setting account. #5665

merged 1 commit into from
May 9, 2023

Conversation

camilasan
Copy link
Member

  • Maintains the space between the layout items when resizing the window.
  • Also remove qobject_cast.

vfs-ui-layout

@camilasan camilasan added this to the 3.8.2 milestone May 8, 2023
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited
Loading

Codecov Report

Merging #5665 (c5db4bb) into master (b0a2150) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c5db4bb differs from pull request most recent head 3bdbed6. Consider uploading reports for the commit 3bdbed6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5665      +/-   ##
==========================================
- Coverage   59.24%   59.23%   -0.02%     
==========================================
  Files         143      143              
  Lines       18458    18458              
==========================================
- Hits        10936    10933       -3     
- Misses       7522     7525       +3

see 1 file with indirect coverage changes

@camilasan
Copy link
Member Author

/rebase

Use addLayout to insert the VFS option when setting account.
3bdbed6 
- Maintains the space between the layout items when resizing
the window.
- Also remove qobject_cast.

Signed-off-by: Camila San <hello@camila.codes>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@camilasan camilasan merged commit ff3695e into master May 9, 2023
@camilasan camilasan deleted the enh/vfs-option-ui branch May 9, 2023 17:27
@camilasan
Copy link
Member Author

/backport to stable-3.8

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 9, 2023
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5665-3bdbed6294c0c28b9f7a2d225b3c1f1395cdf0fd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @claucambra