Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide feedback on share link copy #5672

Merged
merged 7 commits into from
May 16, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented May 10, 2023

Screen.Recording.2023-05-10.at.11.31.56.mov
Screen.Recording.2023-05-11.at.14.11.23.mov

Closes #5669

@claucambra claucambra self-assigned this May 10, 2023
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #5672 (4e91f39) into master (79c0fdc) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4e91f39 differs from pull request most recent head a9375c4. Consider uploading reports for the commit a9375c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
- Coverage   59.38%   59.37%   -0.01%     
==========================================
  Files         143      143              
  Lines       18524    18520       -4     
==========================================
- Hits        11000    10997       -3     
+ Misses       7524     7523       -1     

see 4 files with indirect coverage changes

@claucambra claucambra force-pushed the bugfix/provide-feedback-on-share-link-copy branch from 4e91f39 to 1106cc1 Compare May 16, 2023 13:15
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…action completed obvious

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…nk button with constants defined in Style.qml

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/provide-feedback-on-share-link-copy branch from 1106cc1 to a9375c4 Compare May 16, 2023 13:16
@claucambra claucambra merged commit 4dfab45 into master May 16, 2023
@claucambra claucambra deleted the bugfix/provide-feedback-on-share-link-copy branch May 16, 2023 13:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5672-a9375c4d64f6ead7480cd4515b5cdbf8cc62842c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No visual feedback when clicking a button in the share dialog.
4 participants