Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening a file or folder in the local sync root. #5686

Merged
merged 1 commit into from
May 16, 2023

Conversation

allexzander
Copy link
Contributor

It was impossible to open for local editing anything if it was located in the topmost (root) local sync folder.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #5686 (81ecba8) into master (2d27e4a) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5686      +/-   ##
==========================================
- Coverage   59.28%   59.27%   -0.01%     
==========================================
  Files         143      143              
  Lines       18463    18467       +4     
==========================================
+ Hits        10945    10947       +2     
- Misses       7518     7520       +2     
Impacted Files Coverage Δ
src/libsync/syncengine.h 65.00% <ø> (ø)
src/libsync/syncengine.cpp 80.69% <83.33%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but once changed looks good

src/libsync/syncengine.h Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the bugfix/edit-locally-allow-opening-item-in-root branch 2 times, most recently from 8a8b33a to 3172bd2 Compare May 16, 2023 10:01
@allexzander
Copy link
Contributor Author

/backport to stable-3.8

Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the bugfix/edit-locally-allow-opening-item-in-root branch from 3172bd2 to 81ecba8 Compare May 16, 2023 10:33
@allexzander allexzander merged commit 79c0fdc into master May 16, 2023
@allexzander allexzander deleted the bugfix/edit-locally-allow-opening-item-in-root branch May 16, 2023 11:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5686-81ecba8daaa36acb837c3f906870122d4cc17c76-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants