Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] Fix macOS icon #5762

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5757

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.0 milestone Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #5762 (00ba4e6) into stable-3.9 (651c749) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 00ba4e6 differs from pull request most recent head f419cb7. Consider uploading reports for the commit f419cb7 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.9    #5762      +/-   ##
==============================================
+ Coverage       60.26%   60.36%   +0.10%     
==============================================
  Files             143      143              
  Lines           18518    18518              
==============================================
+ Hits            11159    11179      +20     
+ Misses           7359     7339      -20     

see 7 files with indirect coverage changes

This reverts commit 04d16b7.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the backport/5757/stable-3.9 branch from 00ba4e6 to f419cb7 Compare June 6, 2023 14:06
@claucambra claucambra merged commit 542f464 into stable-3.9 Jun 6, 2023
@claucambra claucambra deleted the backport/5757/stable-3.9 branch June 6, 2023 14:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5762-f419cb72936211c5bb97028aad76caff162256b3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants