Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert inclusion of File Provider module in 3.9 branch #5772

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Revert inclusion of File Provider module in 3.9 branch #5772

merged 2 commits into from
Jun 7, 2023

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra requested review from mgallien and misch7 June 6, 2023 14:03
@claucambra claucambra self-assigned this Jun 6, 2023
@claucambra claucambra changed the title Bugfix/revert 3.9 fp Revert inclusion of File Provider module in 3.9 branch Jun 6, 2023
@claucambra claucambra requested review from camilasan and allexzander and removed request for misch7 June 6, 2023 14:04
@claucambra claucambra force-pushed the bugfix/revert-3.9-fp branch from 10847fb to 99b6c45 Compare June 6, 2023 14:05
github-actions[bot]
github-actions bot requested changes Jun 6, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

shell_integration/MacOSX/OwnCloudFinderSync/FinderSyncExt/FinderSync.h Show resolved Hide resolved
shell_integration/MacOSX/OwnCloudFinderSync/FinderSyncExt/LocalSocketClient.m Show resolved Hide resolved
shell_integration/MacOSX/OwnCloudFinderSync/FinderSyncExt/LineProcessor.m Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 6, 2023 •
edited
Loading

Codecov Report

Merging #5772 (10847fb) into stable-3.9 (00ba4e6) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 10847fb differs from pull request most recent head be88d7a. Consider uploading reports for the commit be88d7a to get more accurate results

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.9    #5772      +/-   ##
==============================================
+ Coverage       60.36%   60.38%   +0.02%     
==============================================
  Files             143      143              
  Lines           18518    18510       -8     
==============================================
- Hits            11179    11178       -1     
+ Misses           7339     7332       -7
Impacted Files Coverage Δ
src/libsync/configfile.cpp 26.66% <ø> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

@claucambra claucambra enabled auto-merge (rebase) June 7, 2023 08:33
claucambra added 2 commits June 7, 2023 16:33
@claucambra
Revert "Merge pull request #5742 from nextcloud/backport/5707/stable-…
8e61ac3 
…3.9"

This reverts commit 5118bcf, reversing
changes made to d9603fc.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Revert "Merge pull request #5527 from nextcloud/feature/file-provider…
be88d7a 
…-try-2"

This reverts commit c4d1211, reversing
changes made to 9b77da6.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/revert-3.9-fp branch from 99b6c45 to be88d7a Compare June 7, 2023 08:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5772-be88d7a624f9e7ad44235ec4aefc7a6d270c6c79-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

allexzander
allexzander approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, thanks

@claucambra claucambra merged commit 21c5dec into stable-3.9 Jun 7, 2023
@claucambra claucambra deleted the bugfix/revert-3.9-fp branch June 7, 2023 10:00
@berezovskyi berezovskyi mentioned this pull request Jun 13, 2023
Merged
@mgallien mgallien added this to the 3.9.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@allexzander allexzander allexzander approved these changes

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @nextcloud-desktop-bot @camilasan @allexzander @mgallien