Improve Settings dialog design. #6150
Conversation
allexzander
requested review from
mgallien,
camilasan,
claucambra,
nimishavijay and
jancborchardt
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6150 +/- ##
==========================================
- Coverage 60.74% 60.54% -0.20%
==========================================
Files 145 145
Lines 18829 18833 +4
==========================================
- Hits 11438 11403 -35
- Misses 7391 7430 +39
|
Done d58dd8d |
allexzander
force-pushed
the
feature/settings-dialog-design-improvements
branch
from
d58dd8d to
8d7a2f8
Compare
src/gui/generalsettings.cpp
Outdated
| QString about = Theme::instance()->about(); | ||
| Theme::replaceLinkColorStringBackgroundAware(about); | ||
| _ui->aboutLabel->setText(about); | ||
| auto aboutText = Theme::instance()->about(); |
There was a problem hiding this comment.
| auto aboutText = Theme::instance()->about(); | |
| const auto aboutText = Theme::instance()->about(); |
There was a problem hiding this comment.
@mgallien Impossible, see void Theme::replaceLinkColorStringBackgroundAware(QString &linkString); that expects non-const reference
src/libsync/theme.cpp
Outdated
|
|
||
| devString += tr("<p>Version %1. For more information please click <a href='%2'>here</a>.</p>") | ||
| .arg(QString::fromLatin1(MIRALL_STRINGIFY(MIRALL_VERSION)) + QString(" (%1)").arg(osName)) | ||
| .arg(helpUrl()); | ||
| .arg(QString::fromLatin1(MIRALL_STRINGIFY(MIRALL_VERSION)) + QString(" (%1)").arg(osName)) |
There was a problem hiding this comment.
please use the arg overload taking multiple strings at once. they are faster
There was a problem hiding this comment.
maybe even try to change this long complicated method to build teh string by using placeholders and a single arg call ?
There was a problem hiding this comment.
@mgallien modified where string translations don't break
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander
force-pushed
the
feature/settings-dialog-design-improvements
branch
from
71e0aa7 to
bc91eac
Compare
|
AppImage file: nextcloud-PR-6150-bc91eac2e55097c12dbe65bd559315fc65f41c1c-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
|
Btw @allexzander the general style which still looks a bit outdated (grey background and the containers) I assume is blocked by having a new Qt version which looks more like Windows 10 or hopefully even 11? |
|
@jancborchardt I guess tracked here #4584 |
For #5142
Before:
settings_and_network_dialog_before.mp4
After:
settings_and_network_dialog_after.mp4