Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when updating enabled File Provider domains (macOS VFS) #6833

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Fix crash when updating enabled File Provider domains (macOS VFS) #6833

merged 6 commits into from
Jun 25, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 25, 2024 •
edited
Loading

Closes #6730

@claucambra claucambra requested review from mgallien and camilasan June 25, 2024 10:56
@claucambra claucambra self-assigned this Jun 25, 2024
@claucambra claucambra added this to the 3.13.1 milestone Jun 25, 2024
@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

camilasan
camilasan approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@claucambra
Take AccountPtr by reference in accountstate constructor
fd4ddfd 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Remove overwrought loadFromSettings method from AccountState
74a7824 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Assert validity of accountstate and its accountptr when adding it
1689f7b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Use accountfwd header for account forward declaration in account head…
07d5e40 
…er itself, preventing conflicting decls

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Prevent crash when updating file provider domains if the account for …
fc2e687 
…which a file provider domain was configured no longer exists

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Remove no longer existing account id from configured vfs accounts list
73fc23f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/fp-account-crash branch from a0076e8 to 73fc23f Compare June 25, 2024 15:01
@claucambra claucambra merged commit 566e8b7 into master Jun 25, 2024
11 of 13 checks passed
@claucambra claucambra deleted the bugfix/fp-account-crash branch June 25, 2024 15:04
@backportbot backportbot bot mentioned this pull request Jun 25, 2024
Merged
2 tasks
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6833-73fc23f0025bfc9657b0481f72a6fd74bf5668bd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
feature: 💽 virtual filesystem os: 🍎 macOS
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

[Bug]: Segmentation Fault with new VFS on MacOS
3 participants
@claucambra @nextcloud-desktop-bot @camilasan