Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure log context category is valid before reading it #7271

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Oct 7, 2024

category of logs accessed via log context can be null in such a case, strcmp will crash

category of logs accessed via log context can be null
in such a case, strcmp will crash

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/fixPermanentDeleteLogCrash branch from 82e0a51 to 35d4f91 Compare October 7, 2024 15:04
@mgallien mgallien merged commit c01ca5b into master Oct 7, 2024
10 of 14 checks passed
@mgallien mgallien deleted the bugfix/fixPermanentDeleteLogCrash branch October 7, 2024 15:04
@mgallien
Copy link
Collaborator Author

mgallien commented Oct 7, 2024

/backport to stable-3.12

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7271-35d4f91b42f7b468bfe01ee160900f419b409a90-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants