Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.14] Bugfix update channels #7443

Merged
merged 10 commits into from
Oct 31, 2024
Merged

[stable-3.14] Bugfix update channels #7443

merged 10 commits into from
Oct 31, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 31, 2024

Backport of PR #7350

@camilasan @backportbot
Remove checks for the update channel from the getter function.
e46e4e2 
It should only return the value.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Change the list of update channels when server capabilities change.
dcd3b01 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Do not override the subscription value if one of the account has ente…
3cfda35 
…rprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Do not override the channels list if one of the account has enterprise.
b9e88ce 
Maintain stable and enterprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Save serverHasValidsubcription in the account.
4c942a5 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Fix logic for initial load of update channels and priority for user w…
09219a2 
…ith subscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Update config value when serverHasValidSubscription when accounts are…
093772f 
… added or removed.

To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Address PR feedback.
b0e8b19 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Remove check in setServerHasValidSubscription.
1438464 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @backportbot
Fix compiling when BUILD_UPDATER is set to OFF.
3b2a1cc 
Only connect signal/slot for update channels listing when BUILD_UPDATER is ON.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@backportbot backportbot bot requested review from mgallien and camilasan October 31, 2024 13:30
@backportbot backportbot bot added this to the 3.14.4 milestone Oct 31, 2024
@mgallien mgallien merged commit e582c96 into stable-3.14 Oct 31, 2024
10 of 14 checks passed
@mgallien mgallien deleted the backport/7350/stable-3.14 branch October 31, 2024 13:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7443-3b2a1cc2871bbb5d9d26abf41e074b7c1fa5ed87-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
24.4% Coverage on New Code (required ≥ 80%)
7 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@camilasan camilasan

Labels
3. to review
Projects
None yet
Milestone
3.14.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nextcloud-desktop-bot @mgallien @camilasan