-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading 28.0.0 bz2 module missing #2118
Comments
Furthermore, if you click on the documentation link ( |
True, but this is most likely an issue with Nextcloud in general / the fact that they have not yet updated the documentation and not the nextcloud docker container in particular. |
yes i confirm it. after i updated my nextcloud app to version 28.0.0 i got the same warning about the bz2. and also the link is not working. this is the correct link to the recommended modules from Nextcloud documentation: https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html |
I can confirm i have the same issue on a full fresh install of latest fpm docker image. As a workaround i have created a local Dockerfile that uses NC as base image and just installs the bz2 php module, to keep it across downs/ups of compose, since it was fresh install and it needed a bit of fiddling with.
|
Old pull request regarding this issue: #1351 |
Just to hammer the point that was made in that other issue, I agree that Nextcloud can't include everything in the image. But now they "highly recommend" bz2 and there's a big warning about it on the Security & Setup Warnings page:
That means on a brand new installation using Docker, users are expected to figure out how to make their own customized version of a Dockerfile just to add this dependency. It doesn't just work out of the box. Sorry, but that is dumb. |
This comment was marked as spam.
This comment was marked as spam.
certain sense of deja-vu here too.... |
That one apparently took a quick 1,5 years to resolve, fingers crossed for this new one 😃 |
The change was introduced in nextcloud/server#40889 (comment) but as stated there and in #1351 (comment) |
@J0WI in that case it's strange that we are seeing this new warning that wasn't there before. It sounds like the bug isn't the missing module, but the actual message that needs to be removed. That would also mean this issue needs to go in the server repo, not Docker. Anyone else agree? |
@J0WI I just fix it. My PR will be an option. |
how to fix this when I use Podman, not Docker. Thanks in advance/ |
My suggestion is that no one build a custom image merely to fix this warning that isn't impacting anything operationally. The check for bz2 was added in a bundle of other php module checks. There's a 50/50 chance bz2 gets removed from the docs and the check goes away. Tracking upstream in nextcloud/server#42342 |
I agree strongly. |
Could you create a gist and explain how you did that? I create a Dockerfile with this contest (just used build:
context: .
dockerfile: Dockerfile to my So a minimal example of a |
Hello, Create an empty folder named app in the location of the compose file. Inside create the following dockerfile, and edit as needed, in my case i need ffmpeg for video files preview as well, but feel free to remove it. FROM nextcloud:28.0.1-fpm
RUN apt-get update && apt-get install -y libbz2-dev ffmpeg && rm -rf /var/lib/apt/lists/*
RUN docker-php-ext-install bz2 Then my compose file looks like this (keep in mind, it's not the default, but you can adjust it as needed) app:
build: ./app
restart: unless-stopped
logging:
driver: "json-file"
options:
max-size: "50m"
volumes:
- nextcloud:/var/www/html
- ./opcache-recommed.ini:/usr/local/etc/php/conf.d/opcache-recommended.ini
environment:
- POSTGRES_HOST=db
- REDIS_HOST=redis
- PHP_MEMORY_LIMIT=1024M
env_file:
- db.env
depends_on:
- db
- redis
cron:
build: ./app
restart: unless-stopped
logging:
driver: "json-file"
options:
max-size: "50m"
volumes:
- nextcloud:/var/www/html
entrypoint: /cron.sh
depends_on:
- db
- redis Then start the containers with the build and pull params (note, you can also do a separate compose build --pull, but i find this way more "safe") docker compose up --build --pull always -d Few notes:
|
Thanks, this is working @tzerber.
I get a
I wrote myself some sort of update script so i can pass the version like
I also want to switch from apache to nginx, but it is difficult to realize this with the appropriate containers. I could use |
This is because you are using
I recently updated some of the examples in the docker examples section you can use that as example. If you can't manage it, i can probably write you a proper example, but we're derailing this issue thread sooo much that i expect someone from maintainers will come yell at us :D |
This comment was marked as duplicate.
This comment was marked as duplicate.
This is the docker section. In general, you need to install the php bz2 extension depending on your PHP version, probably php8.2-bz2 to get rid of the warning. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
@Ramalama2 That's not what is going on here. There is an upstream issue in Server this one tied into. This one is blocked on clarification there. The |
Thats not the point. The point is that a docker image is published which causes warning messages. All manual things done to fix the warning message are workarounds. For us this is a no-go as Nextcloud runs in K8S. We neither want to use our own image, nor want to manually change running pods. |
I don't agree here. The whole idea of using docker is to use only the software that's needed for an application to function properly, nothing more nothing less. The presence of bz2 php extension in the container is not needed, no app or functionality is requiring it. You will get surprised how much software on this planet works fine despite throwing a lot more core warnings (and more obvios ones) than this single one we're discussing here. The official docker image of Nextcloud also does not have that php extension. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This is more of a contribution-powered project, and it's not related to Nextcloud GmbH, just a bunch of folks (nextcloud-employed or not) trying to offer micro-service variant of the official Nextcloud / Nextcloud-Docker-AIO variant. And the folks here are trying their best to keep it as 1:1 with the upstream as possible, and if something is wrong or causing issues coming from upstream to report/fix them there, not just turn this repository in a Nextcloud-workarounds one.
While the problem with the warning is settled with upstream Nextcloud (should or we shouldn't install bz2 module regardless of docker environment or not ) you can workaround this problem if you want to get rid of the warning by using a modified Docker file as shown here : |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I'm currently maintaining an image that solves these issues that appear when using a brand new docker image. I've installed I'm building it for |
@jiriks74 Thanks for that. However, besides this docker image being "unofficial" whatever that means at this point, @J0WI marked #1351 as "wontfix" so we can't even fix the issue with a PR in this repo. My point is that the Nextcloud team isn't allowing the community to fix the "most upstream" Docker image for lack of a better term, and using something even less "official" isn't the best long term solution. It looks like they are pushing people toward the AIO instance, which does include bz2 by the way, but migrating to that is more complicated than using this image with a supported database, etc. I just don't understand why this repo exists... if the Nextcloud team is going to be obnoxious about it and say it's not supported, but also not let the community update it as we see fit, then let's just delete it, right? |
Please keep this issue on topic. This is still open to track the upstream issue at nextcloud/server#42342. #1351 is on hold until this is sorted out. The warning means nothing, bz2 is not used by any app. It's like a false-positive and completely fine to ignore. Unfortunately there wasn't much attention yet on nextcloud/server#42342. Meanwhile I've proposed patches to revert this change introduced in nextcloud/server#40889: Please stay patient while we're all waiting for a proper fix or clarification in Nextcloud itself. Whatever is decided there will be implemented here. |
The upstream issue nextcloud/server#42342 was just closed via nextcloud/server#42821 by removing |
Quick update: The backport to v28 was merged in nextcloud/server#43013 a few moments ago. So it's officially in, but it'll be in v28.0.3. It was not able to be merged into the just released v28.0.2 because it was already in a code freeze at the time. |
@joshtrichards Do you know when the latest point releases (28.0.3, 27.1.7) will have their respective docker images published? Rough estimate or timeline? |
https://github.com/docker-library/faq?tab=readme-ov-file#an-images-source-changed-in-git-now-what |
Scheduled release: docker-library/official-images#16353 |
After upgrading to nextcloud 28.0.3 (nextcloud:latest on dockerhub), the error actually disappears. |
After upgrading nextcloud 28.0.0 (nextcloud:latest on dockerhub) I am getting the following error :
Otherwise, apart from a few apps that don't work , I haven't identified any major problems.
The text was updated successfully, but these errors were encountered: