Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for oauth in docker image #1023

Closed
wants to merge 4 commits into from

Conversation

monperrus
Copy link

@kesselb
Copy link
Contributor

kesselb commented Mar 9, 2020

That looks like the wrong way to add a new php extension. Please check: https://github.com/docker-library/docs/blob/master/php/README.md#how-to-install-more-php-extensions

@monperrus
Copy link
Author

Thanks a lot for the pointer, fixed.

@kesselb
Copy link
Contributor

kesselb commented Mar 12, 2020

Still looks wrong. Afaik apt-get is not the right way to install a php package.

@monperrus
Copy link
Author

thanks for the feedback.

unclear to me whether oauth should be installed with docker-php-ext-enable or PECL/docker-php-ext-enable.

Here is a WIP version full PECL, WDYT?

@J0WI
Copy link
Contributor

J0WI commented Mar 30, 2020

Since this is not required by default apps I'd prefer moving this to our examples: https://github.com/nextcloud/docker/tree/master/.examples#dockerfiles

@monperrus
Copy link
Author

We really want to use grauphel but it's more important for us to depend on the official Docker image of Nextcloud.

So if we don't merge this feature, it's basically a NO-GO for grauphel and all plugins depending on oauth.

@monperrus
Copy link
Author

Here is how to activate oauth for grauphel.

Works for me in a Docker container running Nextcloud 23:

apt install libpcre3-dev
pecl install oauth
echo extension=oauth.so > /usr/local/etc/php/conf.d/oauth.ini
service apache2 restart

@J0WI
Copy link
Contributor

J0WI commented Apr 4, 2023

Unfortunately we can't include every extension by default. The requirements for Nextcloud itself are listed in https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
Custom apps and other custom requirements can be installed using hooks (as proposed in #820) or by building a child image.

@J0WI
Copy link
Contributor

J0WI commented Jun 22, 2023

Closing in favour of #1964.

@J0WI J0WI closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tomboy Notes server not installable in Nextcloud 13 app store (docker)
3 participants