-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for oauth in docker image #1023
Conversation
That looks like the wrong way to add a new php extension. Please check: https://github.com/docker-library/docs/blob/master/php/README.md#how-to-install-more-php-extensions |
Thanks a lot for the pointer, fixed. |
Still looks wrong. Afaik apt-get is not the right way to install a php package. |
thanks for the feedback. unclear to me whether Here is a WIP version full PECL, WDYT? |
Since this is not required by default apps I'd prefer moving this to our examples: https://github.com/nextcloud/docker/tree/master/.examples#dockerfiles |
We really want to use grauphel but it's more important for us to depend on the official Docker image of Nextcloud. So if we don't merge this feature, it's basically a NO-GO for grauphel and all plugins depending on oauth. |
Here is how to activate oauth for grauphel. Works for me in a Docker container running Nextcloud 23:
|
Unfortunately we can't include every extension by default. The requirements for Nextcloud itself are listed in https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation |
Closing in favour of #1964. |
Fix grosjo/nextcloud-grauphel#55