Install apps via env var for initial setup #1259
Conversation
mgerhardy
force-pushed
the
pr/install-apps
branch
from
1a70554 to
861ece4
Compare
mgerhardy
force-pushed
the
pr/install-apps
branch
from
861ece4 to
0b6fbb6
Compare
|
I am currently running this in my entrypoint, I hope this gets pushed soon as without this feature the auto deployment of apps is hard. |
| @@ -168,6 +168,12 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP | |||
| NC_TRUSTED_DOMAIN_IDX=$(($NC_TRUSTED_DOMAIN_IDX+1)) | |||
| done | |||
| fi | |||
| if [ -n "${NEXTCLOUD_INSTALL_APPS+x}" ]; then | |||
| echo "Install apps…" | |||
| echo "$NEXTCLOUD_INSTALL_APPS" | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//' | tr " " \\n | while read APP; do | |||
There was a problem hiding this comment.
This breaks with multiple spaces. I guess a comma separated list would be much easier
There was a problem hiding this comment.
As far as i can see this only affects apps which have Space in their name... Does this really happen?
I'd be willing to contribute an implementation which parses a comma separated list, everything that needs to happen to get this PR in as soon as possible! 🚀 :)
There was a problem hiding this comment.
Will you consider PR #1260 ? Would be great to have a more flexible way to configure Nextcloud for the automatic installation.
At Nextcloud (you're working there ?), did you think about enabling all options for autoconfig.php ? Would it be possible to enable more configuration variables there ?
It would be a great thing to have a way to automate the entire installation !
Edit: See Synapse (matrix server) who deprecated env var for burden maintenance and support install only through passing config files.
There was a problem hiding this comment.
Yes, I think I'll prefer #1260
|
Closing in favour of #1964. |
Should fix issues