Bug fix: not found error if hook folder contains files but non ending with *.sh
#2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Vestergaard Værum <github@varum.dk>
Signed-off-by: Dennis Vestergaard Værum <github@varum.dk>
J0WI
reviewed
Nov 10, 2023
Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Dennis Værum <6872940+dvaerum@users.noreply.github.com>
Small adjustments Signed-off-by: Dennis Værum <6872940+dvaerum@users.noreply.github.com>
J0WI
approved these changes
Nov 14, 2023
|
@J0WI, thanks for merging and a pleasure to work with you again 😁 |
|
Thanks, @dvaerum, for addressing so quickly! |
J0WI
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Fix docker-entrypoint.sh Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com> * Fix docker-entrypoint.sh for alpine Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com> * Use '-o' instead of two find's in docker-entrypoint.sh Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com> * Use more laconic find parameters set in docker-entrypoint.sh Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com> --------- Signed-off-by: Yevhen Kolomeiko <Jarvis2709@gmail.com>
ananace
pushed a commit
to ananace/docker-nextcloud
that referenced
this pull request
May 10, 2024
… with `*.sh` (nextcloud#2095) * Use `find` to located `*.sh` Signed-off-by: Dennis Vestergaard Værum <github@varum.dk> * added msg if hook folder does not exist Signed-off-by: Dennis Vestergaard Værum <github@varum.dk> * Updated info message Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Dennis Værum <6872940+dvaerum@users.noreply.github.com> * Update docker-entrypoint.sh Small adjustments Signed-off-by: Dennis Værum <6872940+dvaerum@users.noreply.github.com> --------- Signed-off-by: Dennis Vestergaard Værum <github@varum.dk> Signed-off-by: Dennis Værum <6872940+dvaerum@users.noreply.github.com> Co-authored-by: J0WI <J0WI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the bug which was introduced by me in
#1964
and reported in
#2094
If there is a good way to make unittest for this, I am all ears.