Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MariaDB 10.11 #2298

Merged
merged 1 commit into from
Oct 8, 2024
Merged

MariaDB 10.11 #2298

merged 1 commit into from
Oct 8, 2024

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Sep 18, 2024

No description provided.

@joshtrichards joshtrichards added the examples Compose/Dockerfile/etc label Sep 18, 2024
@tzerber
Copy link
Contributor

tzerber commented Sep 18, 2024

Hi, i've been working on the examples and I saw this. While looking at "should or shouldn't use --log-bin=binlog", i stumbled across a lot of mysql compose files on legitimate repos like Wise's and they all point to this issue when using 10.11 MariaDB. Should we add this

    security_opt: # see https://github.com/MariaDB/mariadb-docker/issues/434#issuecomment-1136151239
      - seccomp:unconfined
      - apparmor:unconfined

to the compose files in the examples + the readme once 10.11 is in use ? I will give it a test tomorrow to see if it actually works, because that issue appears closed.

@joshtrichards
Copy link
Member

Interesting - and thanks for watching out for stuff l like this.

I did a quick look and I think it's limited to old Docker Engine / runtimes w/ outdated seccomp policies. I didn't do too deep of a dive though admittedly.

I'd rather not include a workaround for something that is probably not common / should be fixed in other ways

If it was (or still is) a big enough deal, MariaDB presumably has a doc link somewhere we can just link to and say "do whatever they say" if impacted by this.

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@joshtrichards
Copy link
Member

I say let's merge this. I'll do a similar one for the postgresql examples.

@joshtrichards joshtrichards added this to the Nextcloud 30.0.1 milestone Oct 7, 2024
@J0WI J0WI merged commit 5a242f6 into nextcloud:master Oct 8, 2024
21 checks passed
@J0WI J0WI deleted the mariadb-10.11 branch October 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Compose/Dockerfile/etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants