-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for Android Deep Link Handling #12075
base: master
Are you sure you want to change the base?
Conversation
f192dba
to
2e330ae
Compare
046ea76
to
15186a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This page is not included anywhere
- Heading lines do not match the heading text length
- Heading structure makes no sense. There should be a page title, then sections, etc. Right now there are four sections with
=
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
admin_manual/configuration_server/android_deep_link_handling.rst
Outdated
Show resolved
Hide resolved
Replace APP_SHA256_FINGERPRINT with the SHA-256 fingerprint of your app’s | ||
signing certificate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is only applicable to branded apps, right?
This either needs a big caveat at the top of the chapter or maybe it shouldn't be included here since it's not applicable to community users... so maybe it only belongs in the customer docs in https://portal.nextcloud.com somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alperozturk96 this also works for our official app, right?
So maybe add the sha256 of our app here.
And as Josh suggested, add a portal entry how this needs to be changed for branded apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobiasKaminsky How can I add portal entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The globbing recently added in #11691 should pick it up. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good structure-wise. Can't say much about the content :)
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: alperozturk <alper_ozturk@proton.me>
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
f4a1b27
to
21ebe10
Compare
Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com>
Is this intended as an alternative approach to nextcloud/server#44665? |
No, that PR is only functional for us. If a user wants to use it with a different server name, it will not work on Android 12 or above. For more details |
☑️ Resolves
This pull request includes documentation for handling deep links in Android applications, specifically addressing the requirements and configurations for Android 12 and above.
🖼️ Screenshots