Extra documentation for smb update notification with user provided auth #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
reviewed
Jan 23, 2018
| Using login credentials is only supported with 'Login credentials, save in database'. | ||
|
|
||
| When using 'Login credentials, save in database' or 'User entered, stored in database' authentication the notify process | ||
| is not able to read the smb credentials from the storage configuration, in those cases you can provide |
There was a problem hiding this comment.
This sentence is the opposite of the paragraph before it. Could you check it again?
There was a problem hiding this comment.
it's correct, although it might look a bit conflicting.
The notify command can't use the '... save in database' credentials because it is not running in the context of a user.
The file scanner can use the credentials because it is run within a user context so it knows which set of credentials to pick
There was a problem hiding this comment.
Then write it like that and describe what the difference between notify command and file scanner is ;)
|
@icewind1991 Could you refine the sentence to make it a bit more clear? Thanks |
icewind1991
force-pushed
the
smb-notify-document-auth
branch
from
126f8b5 to
7946be1
Compare
|
Cleared it up a bit |
MorrisJobke
approved these changes
Feb 6, 2018
|
stable12 32241b6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the limitations to update notifications as described in nextcloud/server#3524