Documentation bump #684
Documentation bump #684
Conversation
developer_manual/design/index.rst
Outdated
| @@ -5,6 +5,7 @@ Design guidelines | |||
| .. toctree:: | |||
| :maxdepth: 2 | |||
|
|
|||
| newbutton | |||
There was a problem hiding this comment.
I'd say this should be part of the navigation section. 😉
There was a problem hiding this comment.
I asked myself the same question! I think you're right :)
There was a problem hiding this comment.
In the other hand, the new button is placed outside of the <div id="app-navigation">, so I'm not really sure. :/
There was a problem hiding this comment.
Why is it placed outside? Then it wouldn't be in the sidebar anymore.
There was a problem hiding this comment.
Hu! I'm an idiot, I wanted to say outside the ul navigation, but yes, this is inside the app-navigation. ^^'
There was a problem hiding this comment.
Nevertheless, we also have a specific settings page which is also in the app-navigation div, so which do you prefer? Inside the navigation page or like this ?
There was a problem hiding this comment.
Ah ok 😉 Makes sense to have them grouped by the "app-navigation". Maybe we should also move the settings stuff to there, since that is in the app-navigation as well.
skjnldsv
force-pushed
the
documentation-bump-14
branch
from
d55f659 to
d686403
Compare
+ Wording fixes and introduction to the full navigation element Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
documentation-bump-14
branch
from
d686403 to
b672fb4
Compare
| ------------- | ||
|
|
||
| A 'new' button is just a stylised button located above the navigation part of your app. | ||
| It can be tied to whatever you want as long as it follow those simple rules. |
There was a problem hiding this comment.
It can be tied to whatever action you want
as long as it follow those simple rules.
?
There was a problem hiding this comment.
Maybe just call it primary action button, since it is then not limited to a create action. And we can get rid of the It can be tied to whatever you want sentence.
| * a menu | ||
| * a settings area | ||
|
|
||
| The 'new' button and the settings area are optional. |
There was a problem hiding this comment.
Should we add a global code block to show a full example?
There was a problem hiding this comment.
Should be clear from the other examples imo.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
documentation-bump-14
branch
from
e5d3a15 to
7633648
Compare
|
@juliushaertl Here we go! :) Also, see comments I made on this pr :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| ------ | ||
|
|
||
| * Stay simple, don't use overcomplicated text in this button. | ||
| * Avoid using sentences longer than one line. |
There was a problem hiding this comment.
Maybe also:
- Only use a single button
|
|
||
| To create a settings area create a div with the id ``app-settings`` inside the ``app-navigation`` div. | ||
|
|
||
| * The data attribute ``data-apps-slide-toggle`` slides up a target area using a jQuery selector and hides the area if the user clicks outside of it. |
There was a problem hiding this comment.
Is the toggling done by server code or do the app developer need to implement it themselves?
| Introduction | ||
| =============== | ||
|
|
||
| The navigation section of any nextcloud app is the left sidebar. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
documentation-bump-14
branch
from
051ce12 to
e31fdc2
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
documentation-bump-14
branch
from
e31fdc2 to
3db48fc
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
Let's get this in! :) |
Let's wait until 13 is branched off. |
|
@MorrisJobke clear? :) |
Pushed |
WIP
Top right header