Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hijack the quota box in the files app #40

Merged
merged 5 commits into from
Jun 14, 2017
Merged

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Current result:
dateien_-nextcloud-_2017-06-12_10 02 14

@jancborchardt
Copy link
Member

People who don't know our architecture (most will not) will be bit confused about the label "External sites app". It doesn't seem very descriptive. Rather maybe "View details" or something, no? Where does it lead to, what can I expect, what does storage have to do with an external site?

@nickvergessen
Copy link
Member Author

Hmm I think you dont understand the architecture here ;)
External sites app allows to add links in multiple positions, one is the quota. So the admin decides about the text and about the target of the link.

@jancborchardt
Copy link
Member

Ok, but then the default text when you add it should still be something other than "External sites app". :) More like " Do you need more space?" or "View details".

@MorrisJobke
Copy link
Member

Ok, but then the default text when you add it should still be something other than "External sites app". :) More like " Do you need more space?" or "View details".

This was just an example text by @nickvergessen 😉

nickvergessen and others added 3 commits June 13, 2017 09:46
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the margin of the second last item to properly show a scrollbar in those cases. Works perfectly 👍

@MorrisJobke MorrisJobke merged commit 4744fc3 into master Jun 14, 2017
@MorrisJobke MorrisJobke deleted the quota-link-in-files-app branch June 14, 2017 03:50
@MorrisJobke
Copy link
Member

I cherry picked all commits (except the revert) to stable12 and tested - worked just fine.

4a1e59a e67bc96 9fb1114 a59b433

Thanks @nickvergessen for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants