-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hijack the quota box in the files app #40
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
People who don't know our architecture (most will not) will be bit confused about the label "External sites app". It doesn't seem very descriptive. Rather maybe "View details" or something, no? Where does it lead to, what can I expect, what does storage have to do with an external site? |
Hmm I think you dont understand the architecture here ;) |
Ok, but then the default text when you add it should still be something other than "External sites app". :) More like " Do you need more space?" or "View details". |
This was just an example text by @nickvergessen 😉 |
This reverts commit c4835de.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved the margin of the second last item to properly show a scrollbar in those cases. Works perfectly 👍
I cherry picked all commits (except the revert) to stable12 and tested - worked just fine. 4a1e59a e67bc96 9fb1114 a59b433 Thanks @nickvergessen for doing this. |
Requires nextcloud/server#5305