Adds template to urls #66
Conversation
lib/Controller/APIController.php
Outdated
| @@ -79,6 +91,10 @@ public function get() { | |||
| $site['icon'] = $this->url->linkToRouteAbsolute('external.icon.showIcon', ['icon' => 'external.svg']); | |||
| } | |||
|
|
|||
| $site['url'] = str_replace('{email}', $email, $site['url']); | |||
There was a problem hiding this comment.
You can combine those 3 calls to one:
$site['url'] = str_replace(['{email}', '{uid}', '{displayname}'], [$email, $uid, $displayname], $site['url']);
pierreozoux
force-pushed
the
template_in_links
branch
from
dadef1a to
057a99b
Compare
|
@nickvergessen Thanks for the feedback, I corrected! |
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Thanks a lot! I'm really excited! |
|
Could we make a release with that? Thanks! |
|
https://apps.nextcloud.com/apps/external/releases?platform=13#13 Sorry I was on vacation... But this will only be available in the upcoming 13 release |
|
@nickvergessen no problems! thanks! |
|
Thanks for this feature. We have upgraded to 13.0.0 RC4, I have browsed apps/external/ directory and saw these changes, but I'm getting I have tried curl -H "OCS-APIRequest: true" https://user:pwd@localhost/ocs/v2.php/apps/external/api/v1 and it works. I thought we could have it for iframe as well. |
closes #64