Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix PDF sidebar shown in PDF thumbnails #115

Merged
merged 1 commit into from
Jan 4, 2019
Merged

[stable14] Fix PDF sidebar shown in PDF thumbnails #115

merged 1 commit into from
Jan 4, 2019

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #113

@danxuliu
Fix PDF sidebar shown in PDF thumbnails
2d20bdc 
The PDF viewer remembers whether the PDF sidebar was open or closed for
each PDF file the last time it was viewed. Thus, when the PDF file is
rendered in a thumbnail the sidebar must be explicitly hidden to ensure
that it will never be shown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 27, 2018
Merged
danxuliu
danxuliu approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

The version number should be bumped before the next release to prevent that the previous CSS file is got from the cache; would it be better to do it know to ensure that it is not forgotten?

@danxuliu danxuliu added this to the Nextcloud 14.0.5 milestone Nov 27, 2018
@MorrisJobke MorrisJobke mentioned this pull request Jan 4, 2019
Merged
3 tasks
@rullzer rullzer merged commit 64d1122 into stable14 Jan 4, 2019
@rullzer rullzer deleted the backport/113/stable14 branch January 4, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 14.0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@rullzer @danxuliu