Ensure the content takes the whole height when we hide the footer #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable24 |
skjnldsv
approved these changes
Jun 23, 2022
|
Needs test fix and node compile :) |
artonge
force-pushed
the
fix/take_whole_height
branch
3 times, most recently
from
8f833e0
to
e8d28d5
Compare
artonge
changed the title
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
fix/take_whole_height
branch
from
e8d28d5
to
4448a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#contentheight is limited by the<footer>height, but we hide the<footer>when the pdf viewer is used, so we need to manually change the#contentheight to take the whole height.